Add pre-push verification and cross-surface update conventions#786
Open
kelos-bot[bot] wants to merge 2 commits intomainfrom
Open
Add pre-push verification and cross-surface update conventions#786kelos-bot[bot] wants to merge 2 commits intomainfrom
kelos-bot[bot] wants to merge 2 commits intomainfrom
Conversation
Address recurring review feedback: agents should run make verify/test before pushing (not just after), and should update all related surfaces when changing user-facing guidance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
needs-triage
needs-kind
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Based on review feedback from recent PRs: - PR #785: reviewer required generic `none` credential type instead of AWS-specific `bedrock`, establishing provider-agnostic API design - PR #783: multiple review rounds corrected flat string Helm values to idiomatic nested dictionaries (controller.resources.requests|limits) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Adds agent conventions based on recurring review feedback:
Run
make verifyandmake testbefore pushing — Workers and PR-responder agents previously pushed code before running any local verification, causing preventable CI failures. Now verification is required before the initial push in both "new PR" and "existing PR" flows.Update all related surfaces together — When changing user-facing guidance, agents must search for all surfaces (docs, CLI output, templates, code comments) that reference the same topic and update them together to avoid inconsistencies.
Provider-agnostic API design — When adding CRD fields or API types, prefer generic abstractions over provider-specific ones (e.g.,
nonecredential type instead ofbedrock). Use existing generic mechanisms likePodOverrides.Envfor provider-specific details.Idiomatic Helm values — Use nested dictionary structures in
values.yaml(e.g.,controller.resources.requests.cpu) instead of flat string-based parameters. Structured data should be proper YAML dictionaries, not strings.Evidence from PR reviews:
claude setup-tokenguidance but missed updating the CLI init template.nonecredential type instead of AWS-specificbedrock, redirecting the contributor to usePodOverrides.Envfor provider-specific details rather than adding dedicated CRD fields.controller.resources.requests|limits), and reviewer noted values should be proper YAML dicts, not empty strings.Files changed:
self-development/kelos-workers.yaml— Add verification step before push in both PR-exists (5a) and no-PR (new step 4b) flowsself-development/kelos-pr-responder.yaml— Add verification before commit+push in step 5self-development/agentconfig.yaml— Add cross-surface consistency, provider-agnostic API, and Helm conventionsAGENTS.md/CLAUDE.md— Add cross-surface consistency, provider-agnostic API, and Helm conventionsWhich issue(s) this PR is related to:
N/A
Special notes for your reviewer:
All new conventions are backed by specific PR review evidence. No speculative rules added.
Does this PR introduce a user-facing change?